fix(desktop): prevent ghost workspace re-appearance on close

[Kitenite]

Summary

• Closing a workspace awaited terminal kills before marking it as deleting, leaving a window where getAllGrouped refetches could resurrect the workspace in the sidebar
• If a new workspace was created during that window, the closed workspace's git metadata (diff stats) would ghost-appear at its old sidebar position
• Aligns workspace close and project close with the existing delete procedure pattern

Changes

• workspaces/procedures/delete.ts: Move markWorkspaceAsDeleting and updateActiveWorkspaceIfRemoved before the async terminal kill in the close procedure; keep hideProjectIfNoWorkspaces after deleteWorkspace (it counts all rows including deletingAt for concurrent deletion safety)
• projects/projects.ts: Batch-set deletingAt on all project workspaces and hide the project before the async terminal kill loop; update active workspace via selectNextActiveWorkspace() before terminal kills (previously used an unfiltered query after deletion); parallelize terminal kills with Promise.all

Test Plan

• Close a workspace and immediately create a new one — verify the closed workspace doesn't briefly reappear in the sidebar
• Close a project — verify all workspaces disappear immediately, not after terminal shutdown
• Close a project with multiple workspaces — verify active workspace switches immediately to a workspace outside the project
• Verify closing still works end-to-end (terminals killed, workspace removed, navigation to next workspace)

Summary by CodeRabbit

• Refactor
  • Improved workspace closure with parallel terminal shutdown for faster performance.
  • Reorganized cleanup to mark workspaces as deleting and update active workspace before terminal termination for more consistent state.
  • Consolidated post-shutdown cleanup and failure accounting to provide clearer outcomes and preserve workspace visibility/order.

[coderabbitai]

📝 Walkthrough

Walkthrough

Reorders close/delete flows: closed workspace IDs are determined early, workspaces are marked deletingAt and project tabOrder cleared before concurrently killing terminals via Promise.all; terminal results determine totalFailed, then workspaces are deleted and last-active workspace is set using selectNextActiveWorkspace/setLastActiveWorkspace.

Changes

Cohort / File(s)	Summary
Project close logic apps/desktop/src/lib/trpc/routers/projects/projects.ts	Adds selectNextActiveWorkspace import; computes closed workspace IDs early, marks workspaces deletingAt, clears project tabOrder, kills terminals in parallel (Promise.all) and derives totalFailed from results, then deletes workspaces and updates last-active workspace via selectNextActiveWorkspace/setLastActiveWorkspace.
Workspace delete procedure apps/desktop/src/lib/trpc/routers/workspaces/procedures/delete.ts	Moves markWorkspaceAsDeleting(input.id) and updateActiveWorkspaceIfRemoved(input.id) to execute before terminal termination; removes the post-delete active-workspace update so terminals are killed while the workspace is already marked deleting.
Manifest package.json	Minor manifest changes (lines added/removed reported).

Sequence Diagram(s)

sequenceDiagram
  participant API as Projects API
  participant DB as Database
  participant Term as TerminalService
  participant WS as WorkspaceService

  API->>DB: compute closedWorkspaceIds(projectId)
  API->>DB: mark workspaces deletingAt(closedWorkspaceIds)
  API->>DB: set project.tabOrder = null
  API->>Term: kill terminals for closedWorkspaceIds (parallel)
  Term-->>API: terminal kill results (success/failure)
  API->>DB: selectNextActiveWorkspace(projectId)
  API->>DB: setLastActiveWorkspace(nextActiveWorkspace)
  API->>WS: delete workspaces(closedWorkspaceIds)
  WS-->>DB: remove workspace rows

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(desktop): update active workspace before slow delete operations #716: Reorders active-workspace selection before slow shutdowns to avoid UI race conditions (closely related control-flow change).
• fix(desktop): prevent workspace from reappearing during deletion #705: Adds/uses deletingAt and adjusts deletion sequencing so workspaces are hidden during deletion (directly related).
• fix(desktop): make it so you can close projects #480: Modifies projects.close flow including terminal shutdown and tabOrder handling (same area of code).

Poem

🐇 I boxed the tabs and set them to sleep,
Marked the burrows as leaving, tidy and neat.
Terminals hush in parallel hum,
Delete, select next — the hops are done. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main fix: preventing ghost workspace re-appearance on close, which is the core objective of the changeset.
Description check	✅ Passed	The description provides a comprehensive summary, explains the problem, lists specific file changes, and includes a detailed test plan, covering all required template sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/wildebeest

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@apps/desktop/src/lib/trpc/routers/workspaces/procedures/delete.ts`:
- Around line 302-312: hideProjectIfNoWorkspaces is called before
deleteWorkspace so the helper still sees the workspace (only marked deletingAt)
and never hides the project; either move the
hideProjectIfNoWorkspaces(input.projectId) call to after
deleteWorkspace(input.id) in the delete procedure (so it runs once the row is
removed) or update the helper in db-helpers.ts to exclude rows with deletingAt
set; update the code paths around markWorkspaceAsDeleting,
getWorkspaceRuntimeRegistry().terminal.killByWorkspaceId, and deleteWorkspace to
ensure hideProjectIfNoWorkspaces runs after the workspace is actually deleted.