refactor(desktop): remove branch switcher from main workspace sidebar

[Kitenite]

Summary

• Remove the branch switcher dropdown from the main workspace (branch workspace) in the sidebar
• Clean up related backend tRPC procedures that are no longer called

Changes

• Deleted BranchSwitcher component — the dropdown UI for switching branches on the main workspace
• Deleted procedures/branch.ts — contained getBranches and switchBranchWorkspace tRPC procedures, only used by the removed component
• Updated workspaces.ts router — removed branch procedures import and registration
• Updated create.ts — removed now-misleading "Use the branch switcher" error message
• Updated barrel export — removed BranchSwitcher from components/index.ts

Test Plan

• Verify sidebar renders correctly for branch workspaces (no branch switcher button)
• Verify sidebar renders correctly for worktree workspaces (unchanged)
• Verify creating a new branch workspace still works via the sidebar footer
• Typecheck passes (bun run typecheck --filter=@superset/desktop)

Summary by CodeRabbit

• Removed Features

  • Removed branch switching dropdown UI from workspace sidebar
  • Removed branch workspace switching and management capabilities

• Changes

  • Simplified error messaging when creating workspaces with explicit branch selection

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR removes the branch-switching feature from both the backend tRPC router and frontend UI. It deletes the branch procedures module, eliminates the BranchSwitcher React component, removes associated router configuration, and simplifies an error message in workspace creation logic.

Changes

Cohort / File(s)	Summary
Branch procedures removal apps/desktop/src/lib/trpc/routers/workspaces/procedures/branch.ts, apps/desktop/src/lib/trpc/routers/workspaces/workspaces.ts	Deleted branch.ts router with getBranches query and switchBranchWorkspace mutation; removed branch procedures import and aggregation from main workspaces router.
Branch UI component removal apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/components/BranchSwitcher/BranchSwitcher.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/components/BranchSwitcher/index.ts, apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/components/index.ts, apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx	Removed entire BranchSwitcher component (219 lines), deleted component and barrel exports, and removed BranchSwitcher usage from WorkspaceListItem rendering.
Error message simplification apps/desktop/src/lib/trpc/routers/workspaces/procedures/create.ts	Shortened error message in createBranchWorkspace when explicit branch conflicts with main workspace branch; no logic flow changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat(desktop): main terminal vs worktrees terminal #437 — Likely introduced the branch workspace procedures and getBranches/switchBranchWorkspace functionality that this PR removes.
• refactor(desktop): extract db helpers from workspaces router #681 — Extracted and modularized branch procedures into separate file structure; these changes reverse that modularization.
• feat(desktop): add path and branch info to workspace header #400 — Reimplements branch listing and switching features with different UI patterns after the removal in this PR.

Poem

🐰 A bunching of branches, once swift to behold,
Now trimmed from the repo, their story retold.
The switcher hops off, the procedures depart,
Simpler workspaces take root in the heart! 🌱

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removing the branch switcher component from the workspace sidebar UI.
Description check	✅ Passed	The description provides a clear summary, detailed changes list, and test plan, covering all critical aspects of the refactoring.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/remove-branch-switcher-and-terminal-nav

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx (1)

414-414: ⚠️ Potential issue | 🟡 Minor

Stale comment references removed component.

The biome-ignore justification still mentions BranchSwitcher as a reason for not using <button>. The suppression itself is still valid (the close button is still nested), but the comment text should be updated.

✏️ Suggested fix

-		// biome-ignore lint/a11y/useSemanticElements: Can't use <button> because this contains nested buttons (BranchSwitcher, close button)
+		// biome-ignore lint/a11y/useSemanticElements: Can't use <button> because this contains nested interactive elements (close button, diff stats)

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉