fix(desktop): fix typecheck error in WorkspaceListItem#1282
Merged
Conversation
…tton Use ref callback instead of passing RefObject directly to avoid HTMLElement vs HTMLButtonElement type incompatibility.
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughRefactors the collapsed item's ref assignment from direct assignment to a callback ref pattern, ensuring the DOM node is properly assigned to itemRef.current during mounting and unmounting lifecycle phases. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspaceListItemwhere aRefObject<HTMLElement>was being passed directly to a<button>element that expectsRef<HTMLButtonElement>HTMLButtonElementtoHTMLElementon assignment — consistent with the pattern already used by the expanded view's<div>refTest plan
bun run typecheckpasses across all 17 packagesSummary by CodeRabbit
No user-facing changes in this release. Internal code improvements have been made to enhance stability.