ci: add sherif monorepo validation to CI checks

[saddlepaddle]

Summary

• Adds a sherif job to the CI workflow that validates monorepo workspace conventions
• Sherif was already installed as a devDependency and running during postinstall, but wasn't enforced in CI

Test plan

• Verify the new sherif CI job passes on this PR

Summary by CodeRabbit

• Chores
  • Enhanced CI pipeline with automated quality checks
  • Updated project dependencies for improved stability and compatibility
  • Refined peer dependency declarations across packages

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request adds a new GitHub Actions CI job named "sherif" for static analysis and updates project dependencies across multiple package.json files, including version bumps for Zod, TanStack DB, and Hono server, plus explicit peer dependency declarations.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration .github/workflows/ci.yml	Added new "sherif" job to run static analysis checks using Bun; configured to run before lint job with steps for checkout, Bun setup, dependency caching, and sherif execution.
Package Dependency Updates apps/streams/package.json, packages/durable-session/package.json	Updated @durable-streams/client, Zod, and @tanstack/db versions; added @hono/node-server dependency to streams; declared explicit peer dependencies (react, @tanstack/react-db, lucide-react) in durable-session.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A sherif hops into the workflow, checking code with care,
Dependencies dance to newer versions fair,
Peer packages declared, no secrets left to hide,
The CI pipeline strengthens—quality as our guide! 🚀

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is mostly complete but is not structured according to the provided template with required sections like 'Related Issues' and 'Type of Change'.	Add the missing template sections: explicitly link related issues, mark the appropriate type of change, detail the testing approach, and add any additional context needed.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding sherif monorepo validation to CI checks, which aligns perfectly with the primary modification in .github/workflows/ci.yml.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch add-sherif-ci

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ✅ Electric Fly.io app

Thank you for your contribution! 🎉

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/hooks/useFileTree.ts (1)

93-129: ⚠️ Potential issue | 🟠 Major

Stale childrenCache when includeHidden toggles.

When includeHidden changes (user toggles hidden files), the root query refetches automatically (new query key), but childrenCache is never cleared. The early return on line 97 will keep serving stale cached children that were fetched with the old includeHidden value. Only the explicit refetch() (line 135-138) clears the cache.

Consider clearing childrenCache when includeHidden changes:

🐛 Proposed fix

Add an effect to clear the children cache when includeHidden changes (or fold it into existing logic):

+	useEffect(() => {
+		setChildrenCache({});
+	}, [includeHidden]);
+
 	const loadChildren = useCallback(

Alternatively, incorporate includeHidden into the cache key structure so entries fetched with different settings don't collide.

🧹 Nitpick comments (2)

apps/desktop/src/lib/trpc/routers/workspaces/utils/teardown.ts (1)

14-18: Nit: runTeardown uses three positional parameters.

Per coding guidelines, functions with 2+ parameters should use object parameters. This is pre-existing, so not blocking.

♻️ Suggested signature

-export async function runTeardown(
-	mainRepoPath: string,
-	worktreePath: string,
-	workspaceName: string,
-): Promise<TeardownResult> {
+export async function runTeardown({
+	mainRepoPath,
+	worktreePath,
+	workspaceName,
+}: {
+	mainRepoPath: string;
+	worktreePath: string;
+	workspaceName: string;
+}): Promise<TeardownResult> {

As per coding guidelines: "Use object parameters for functions with 2 or more parameters instead of positional arguments."

apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/hooks/useFileTree.ts (1)

45-45: Nit: shorthand property.

includeHidden: includeHidden can be shortened to includeHidden.

♻️ Proposed fix

-			includeHidden: includeHidden,
+			includeHidden,

Same applies on line 105.