Skip to content

fix(desktop): update TopBar to display project and workspace names together#1233

Merged
Kitenite merged 1 commit into
superset-sh:mainfrom
Ipriyankrajai:feat/workspace
Feb 6, 2026
Merged

fix(desktop): update TopBar to display project and workspace names together#1233
Kitenite merged 1 commit into
superset-sh:mainfrom
Ipriyankrajai:feat/workspace

Conversation

@Ipriyankrajai
Copy link
Copy Markdown
Contributor

@Ipriyankrajai Ipriyankrajai commented Feb 5, 2026

Description

image

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • New Features
    • The top bar project title now displays both workspace and project names for improved context visibility, with expanded display width to accommodate the combined information.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The TopBar component now displays both the workspace and project names combined as "workspace.project.name - workspace.name" instead of just the project name. The maximum width constraint for this centered title was increased from 200px to 300px to accommodate the longer text.

Changes

Cohort / File(s) Summary
TopBar Display Update
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/TopBar/TopBar.tsx
Updated centered title to concatenate workspace and project names with " - " separator; increased max-width from 200px to 300px for improved visibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A TopBar tale, I must confess,
Now shows both names in one address,
Project and workspace, side by side,
With wider space, they both fit snide!
More room to read, less need to hide!

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description only includes the template structure with placeholder comments but lacks substantive implementation details. Add a clear explanation of what changed and why (e.g., 'Updated TopBar to display project and workspace names together'), reference any related issues, select the change type, describe testing performed, and add screenshots showing the UI changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: updating TopBar to display project and workspace names together, matching the code modification that concatenates workspace.name with workspace.project.name.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ipriyankrajai
Copy link
Copy Markdown
Contributor Author

@Kitenite
@iamhenry
#1192

@iamhenry
Copy link
Copy Markdown

iamhenry commented Feb 5, 2026

❤️

@Kitenite Kitenite merged commit f702489 into superset-sh:main Feb 6, 2026
1 check passed
@Kitenite
Copy link
Copy Markdown
Collaborator

Kitenite commented Feb 6, 2026

Lovely, thank @Ipriyankrajai !

@iamhenry
Copy link
Copy Markdown

iamhenry commented Feb 6, 2026

I just noticed this
image

is that in superset already?? @Kitenite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants