fix(desktop): convert unnecessary dynamic imports to static imports

[Kitenite]

Summary

• Converted 6 unnecessary dynamic import() calls to static imports across 5 files in the desktop app
• Main process: @sentry/electron/main in tRPC middleware, node:fs/promises and node:path in window router
• Renderer process: @sentry/electron/renderer in sentry init, @xterm/addon-ligatures in terminal helpers, @xterm/addon-search in terminal lifecycle hook

Test plan

• bun run typecheck passes from apps/desktop
• bun run lint:fix passes from repo root
• Verify desktop app launches and terminals work correctly
• Verify Sentry error reporting still works in both main and renderer processes

Summary by CodeRabbit

• Refactor
  • Improved performance by converting dynamic module imports to top-level static imports throughout the desktop application.
  • Simplified error handling and initialization logic for enhanced code maintainability.
  • Streamlined asynchronous initialization processes to synchronous execution where applicable.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR systematically replaces dynamic imports with top-level static imports across the desktop and renderer modules, spanning Sentry integration, terminal addon initialization, and filesystem operations. Additionally, the Sentry initialization function is converted from asynchronous to synchronous.

Changes

Cohort / File(s)	Summary
Sentry Integration apps/desktop/src/lib/trpc/index.ts, apps/desktop/src/renderer/lib/sentry.ts	Replaced dynamic Sentry imports with top-level static imports; converted initSentry from async to sync, eliminating try/catch wrapper around Sentry calls in error handling.
Terminal Addon Initialization apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/helpers.ts, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/hooks/useTerminalLifecycle.ts	Changed SearchAddon import from type-only to value import; replaced dynamic addon imports with synchronous, guarded construction during terminal setup with centralized error handling.
Filesystem Module Access apps/desktop/src/lib/trpc/routers/window.ts	Moved fs and path module imports from in-function dynamic imports to top-level static imports for file reading operations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Terminal lifecycle refactor #1089: Directly overlaps with terminal lifecycle hook refactoring, modifying the same useTerminalLifecycle patterns and addon initialization logic.
• chore(desktop): upgrade xterm.js to v6.0.0 #1125: Modifies terminal addon integration (Terminal/helpers.ts and xterm addon imports), with shared focus on addon initialization changes.
• feat(desktop): add Sentry error tracking to desktop app #484: Modifies identical Sentry integration points in trpc and renderer modules, introducing related changes to how Sentry is imported and initialized.

Poem

🐰 Hopping through imports with gleeful delight,
Dynamic dances now static and tight,
Async adornments shed, sync takes the stage,
A rabbit's refactor on performance's page! 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main objective of the PR—converting unnecessary dynamic imports to static imports across the desktop application.
Description check	✅ Passed	The PR description covers all required template sections: Summary with specific file and module details, Related Issues (implicit via PR context), Type of Change (Refactor), Testing with clear checkboxes, and context. The description comprehensively explains what was changed and why.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/fix-unnecessary-dynamic-imports-in-desktop-app

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉