Skip to content

fix: nested hidden folders not showing when 'Show Hidden Files' enabled #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelgold3n wants to merge 1 commit into from
+7 −1
Closed

fix: nested hidden folders not showing when 'Show Hidden Files' enabled #1213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...enderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/hooks/useFileTree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ export function useFileTree({
}));
}, [rootEntries]);

// Clear children cache when showHiddenFiles changes to ensure nested
// hidden files/folders are properly shown or hidden
useEffect(() => {
setChildrenCache({});
}, [showHiddenFiles]);
Comment on lines +59 to +63
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/hooks/useFileTree.ts

Repository: superset-sh/superset

Length of output: 4434

Guard against in‑flight loads repopulating stale cache after toggle.

When showHiddenFiles changes, the cache is cleared but any loadChildren request already in flight can still resolve and overwrite the cleared cache with results fetched using the old includeHidden value. Add an epoch guard to ensure stale in-flight results are ignored.

🛠️ Suggested epoch guard to ignore stale results 
-import { useCallback, useEffect, useMemo, useState } from "react";
+import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 const [childrenCache, setChildrenCache] = useState<
 	Record<string, FileTreeNode[]>
 >({});
+const cacheEpochRef = useRef(0);
 useEffect(() => {
+	cacheEpochRef.current += 1;
 	setChildrenCache({});
 }, [showHiddenFiles]);
 const loadChildren = useCallback(
 	async (nodeId: string, nodePath: string): Promise<FileTreeNode[]> => {
 		if (!worktreePath) return [];
+		const requestEpoch = cacheEpochRef.current;
@@
-			setChildrenCache((prev) => ({
-				...prev,
-				[nodeId]: childNodes,
-			}));
+			if (requestEpoch === cacheEpochRef.current) {
+				setChildrenCache((prev) => ({
+					...prev,
+					[nodeId]: childNodes,
+				}));
+			}
🤖 Prompt for AI Agents 
In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/hooks/useFileTree.ts`
around lines 59 - 63, When showHiddenFiles toggles you clear children cache but
in-flight loadChildren calls can still overwrite it; add an epoch guard: create
a mutable epoch ref (e.g., childrenCacheEpochRef) incremented inside the
useEffect that currently calls setChildrenCache({}) and capture the current
epoch when invoking loadChildren in whatever function triggers async loads;
before calling setChildrenCache (or any state update with load results) verify
the captured epoch matches childrenCacheEpochRef.current and ignore the results
if they differ. Update references to loadChildren, setChildrenCache, and the
useEffect that watches showHiddenFiles to use this epoch check so stale
responses don’t repopulate the cleared cache.


const buildTree = useCallback(
(nodes: FileTreeNode[]): FileTreeNode[] => {
return nodes.map((node) => {
Expand Down
2 changes: 1 addition & 1 deletion bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.