fix(desktop): fix file and changes view overflow clipping content#1175
fix(desktop): fix file and changes view overflow clipping content#1175
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughTwo RightSidebar view components (ChangesView and FilesView) receive layout adjustments replacing "h-full" with "flex-1 min-h-0" on root containers for improved flex growth. FilesView additionally restructures its ContextMenu wrapper for enhanced overflow management while preserving functional behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use flex-1 min-h-0 instead of h-full for proper flex child sizing. Wrap ContextMenu in a flex container since it doesn't participate in flex layout.
d00b2a3 to
519b19c
Compare
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
overflow-hiddentooverflow-x-hiddenin nested components to allow vertical content to expand into parent scroll containerTest plan
Summary by CodeRabbit