Skip to content

fix(desktop): fix file and changes view overflow clipping content#1175

Merged
Kitenite merged 1 commit intomainfrom
kitenite/file-view-and-change-view-overflow
Feb 3, 2026
Merged

fix(desktop): fix file and changes view overflow clipping content#1175
Kitenite merged 1 commit intomainfrom
kitenite/file-view-and-change-view-overflow

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Feb 3, 2026

Summary

  • Fix file view and changes view overflow issue where expanded content was clipped
  • Change overflow-hidden to overflow-x-hidden in nested components to allow vertical content to expand into parent scroll container

Test plan

  • Expand sections in Changes view with many files - should now be scrollable
  • Expand file tree in Files view - content should not be clipped
  • Verify horizontal text truncation still works for long file paths

Summary by CodeRabbit

  • Style
    • Improved layout responsiveness in the Changes and Files views with enhanced flex container sizing and overflow handling for better visual stability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 3, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Two RightSidebar view components (ChangesView and FilesView) receive layout adjustments replacing "h-full" with "flex-1 min-h-0" on root containers for improved flex growth. FilesView additionally restructures its ContextMenu wrapper for enhanced overflow management while preserving functional behavior.

Changes

Cohort / File(s) Summary
RightSidebar Layout Updates
apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/ChangesView/ChangesView.tsx
Root container className changed from "flex flex-col h-full" to "flex flex-col flex-1 min-h-0" for improved flex growth and minimum height handling.
FilesView Context Menu & Container Restructuring
apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/FilesView.tsx
Outer container className updated to "flex flex-col flex-1 min-h-0". ContextMenu wrapper restructured with overflow-hidden container; ContextMenuTrigger now uses "h-full" instead of "flex-1 min-h-0"; inner content div receives "h-full overflow-auto"; ContextMenuContent repositioned inside wrapper. Maintains existing functionality with refined layout/overflow behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 Flex grows tall, min-height takes flight,
Containers dance, achieving just right,
Overflow managed with wraps so neat,
Layout perfected, the workspace complete!

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description covers the core changes and test plan but lacks required sections like Type of Change, Related Issues, and Screenshots. Complete the PR description template by adding Type of Change (Bug fix), Related Issues link, and any relevant screenshots demonstrating the fix.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing overflow clipping issues in file and changes views by adjusting overflow properties.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kitenite/file-view-and-change-view-overflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Use flex-1 min-h-0 instead of h-full for proper flex child sizing.
Wrap ContextMenu in a flex container since it doesn't participate in flex layout.
@Kitenite Kitenite force-pushed the kitenite/file-view-and-change-view-overflow branch from d00b2a3 to 519b19c Compare February 3, 2026 21:58
@Kitenite Kitenite merged commit 161c590 into main Feb 3, 2026
3 of 5 checks passed
@Kitenite Kitenite deleted the kitenite/file-view-and-change-view-overflow branch February 3, 2026 21:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2026

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant