handle images in file viewer and diff viewer#1166
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request introduces image file viewing support to the desktop application. It adds a new TRPC procedure Changes
Sequence DiagramsequenceDiagram
participant UI as FileViewerPane (UI)
participant Hook as useFileContent (Hook)
participant TRPC as TRPC Client
participant Server as readWorkingFileImage (Server)
participant FS as File System
UI->>Hook: Request file content with viewMode="rendered"
Hook->>Hook: Check if file is image
alt File is Image
Hook->>TRPC: Call readWorkingFileImage(filePath, worktreePath)
TRPC->>Server: readWorkingFileImage procedure
Server->>FS: Read image file
FS-->>Server: File bytes
Server->>Server: Validate size ≤ 10 MiB
Server->>Server: Detect MIME type
Server->>Server: Encode to base64 data URL
Server-->>TRPC: Return {dataUrl, byteLength} or error
TRPC-->>Hook: Image data with result status
Hook-->>UI: {imageData, isLoadingImage}
else File is not Image
Hook->>Hook: Skip image query
Hook-->>UI: {imageData: undefined, isLoadingImage: false}
end
UI->>UI: Render image or error message based on imageData
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Summary by CodeRabbit
New Features
UI Updates