fix(desktop): update scroll-to-bottom for xterm.js 6.0

[Kitenite]

Summary

• Fix scroll-to-bottom hotkey and button for xterm.js 6.0 compatibility
• Use terminal.scrollToBottom() instead of manually scrolling .xterm-viewport DOM element
• Use terminal.onScroll event instead of viewport scroll listener for detecting scroll position

Test plan

• Open a terminal with scrollback history
• Scroll up in the terminal
• Press the scroll-to-bottom hotkey - should scroll to bottom
• Click the scroll-to-bottom button - should scroll to bottom
• Verify the button visibility updates correctly when scrolling

Summary by CodeRabbit

• Refactor
  • Internal improvements to terminal component handling for enhanced code maintainability.

[coderabbitai]

📝 Walkthrough

Walkthrough

Refactored terminal scroll handling to replace direct DOM event listeners with terminal-provided abstractions. The ScrollToBottomButton component now uses terminal.onScroll() instead of manually querying and listening to viewport elements. The scrollToBottom utility was simplified to remove the optional scroll behavior parameter and directly delegate to terminal.scrollToBottom().

Changes

Cohort / File(s)	Summary
Terminal Scroll Refactoring apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/ScrollToBottomButton/ScrollToBottomButton.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/utils.ts	Migrated from DOM-based scroll event handling to terminal-provided abstractions. Replaced manual viewport listener with terminal.onScroll() hook. Simplified scrollToBottom utility by removing ScrollBehavior parameter and eliminating conditional viewport logic, now directly invoking terminal.scrollToBottom().

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(desktop): ensure terminal scrolls to bottom after restore and resize #864: Modifies terminal scrolling behavior by scheduling scrolls post-write operations using the scrollToBottom utility function being refactored here.
• feat(desktop): add scroll to bottom for terminal #653: Adds scroll-to-bottom feature that directly uses terminal.scrollToBottom() and terminal.onScroll(), both central to these refactoring changes.
• Revert terminal scroll position saving #742: Modifies terminal scrolling codepaths in the same component area, removing viewport-based scroll handling patterns similar to these changes.

Poem

🐰 A rabbit hops through scroll events so free,
Ditching DOM queries for hooks—oh what glee!
No more viewport DOM, just terminal's way,
Cleaner abstractions to brighten the day! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers the key changes and includes a test plan, but uses a custom format instead of the required template structure with sections like 'Related Issues', 'Type of Change', 'Testing', etc.	Restructure the description to follow the required template, including explicit sections for Related Issues, Type of Change (checkbox), and properly formatted Testing section with checkboxes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: updating scroll-to-bottom functionality for xterm.js 6.0 compatibility, which aligns with the changes in both files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/scroll-to-bottom-no-longer-works

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉