fix(marketing): add missing canonicals, FAQPage schema, breadcrumbs, and sitemap entries by saddlepaddle · Pull Request #1146 · superset-sh/superset

saddlepaddle · 2026-02-02T20:44:24Z

Summary

Add self-referencing <link rel="canonical"> to homepage (/) and /community
Add /community to sitemap.ts
Add FAQPage JSON-LD structured data to homepage using existing FAQ Q&A content
Add BreadcrumbList JSON-LD to blog post and changelog entry pages (Home > Section > Title)
Remove invalid SearchAction from WebSite schema (no blog search exists)

Test plan

Verify homepage renders <link rel="canonical" href="https://superset.sh"> in <head>
Verify /community renders its canonical tag
Verify /sitemap.xml includes /community
Validate homepage FAQ JSON-LD at https://search.google.com/test/rich-results
Validate breadcrumb JSON-LD on a blog post page
Validate breadcrumb JSON-LD on a changelog entry page
Confirm WebSite schema no longer contains SearchAction

Summary by CodeRabbit

New Features
- Homepage expanded with new sections: video, trusted-by, features, testimonials, FAQ, and CTA.
- Community page added to site navigation and sitemap.
SEO Improvements
- Breadcrumb structured data added to blog and changelog entries.
- FAQ schema markup added site-wide and canonical alternates included for key pages.
Refactor
- FAQ content unified into a shared source for consistent display and schema.

coderabbitai · 2026-02-02T20:44:40Z

📝 Walkthrough

Walkthrough

Adds FAQPageJsonLd and BreadcrumbJsonLd components, uses BreadcrumbJsonLd on blog and changelog posts, extracts FAQ items into a shared constants module and exposes FAQ structured data on the homepage, adds canonical alternates metadata to pages, and inserts /community into the sitemap.

Changes

Cohort / File(s)	Summary
JSON‑LD components `apps/marketing/src/components/JsonLd/JsonLd.tsx`, `apps/marketing/src/components/JsonLd/index.ts`	Added `FAQPageJsonLd` and `BreadcrumbJsonLd` components and their prop interfaces; removed `potentialAction` (SearchAction) from `WebsiteJsonLd`; re-exported new components.
Blog & Changelog pages `apps/marketing/src/app/blog/[slug]/page.tsx`, `apps/marketing/src/app/changelog/[slug]/page.tsx`	Imported and rendered `BreadcrumbJsonLd` alongside existing `ArticleJsonLd`, providing Home, section (Blog/Changelog), and current item URL entries.
FAQSection refactor `apps/marketing/src/app/components/FAQSection/FAQSection.tsx`, `apps/marketing/src/app/components/FAQSection/constants.ts`, `apps/marketing/src/app/components/FAQSection/index.ts`	Extracted local `FAQItem` type and `FAQ_ITEMS` array into new `constants.ts`; `FAQSection` now imports those and index.ts re-exports them.
Homepage updates `apps/marketing/src/app/page.tsx`	Added exported `metadata` with `alternates.canonical` set to `COMPANY.MARKETING_URL`, imported `FAQPageJsonLd` and `FAQ_ITEMS`, and integrated FAQ JSON‑LD into the homepage render (layout sections adjusted).
Community metadata & sitemap `apps/marketing/src/app/community/page.tsx`, `apps/marketing/src/app/sitemap.ts`	Added `alternates.canonical` to community page metadata; added a static sitemap entry for `/community`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

feat(seo): add robots.txt, sitemap, JSON-LD, and enhanced metadata #965 — modifies marketing JSON‑LD utilities and blog page SEO; strongly related to the JsonLd changes here.
feat(marketing): add Features and FAQ sections to homepage #472 — refactors/introduces FAQSection and FAQ data; related to extracting FAQ constants and homepage FAQ usage.
feat(marketing): add blog system with MDX support #929 — touches the blog post page implementation where BreadcrumbJsonLd is now integrated.

Poem

🐰 I hopped along the site and left tidy little trails,
Breadcrumbs for travelers and FAQs in neat details.
JSON‑LD carrots to help searchers find their way,
Shared questions gathered, shining bright today. ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description provides clear summary and test plan but omits required template sections like Related Issues and Type of Change.	Complete the PR description template by adding Related Issues section and selecting applicable Type of Change checkbox.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: adding canonicals, FAQPage schema, breadcrumbs, and sitemap entries.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch add-missing-canonicals-faqpage-schema-sitemap-entr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-02-03T03:35:54Z

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

✅ Neon database branch
✅ Electric Fly.io app

Thank you for your contribution! 🎉

…and sitemap entries Add self-referencing canonicals to homepage and /community, add /community to sitemap, add FAQPage JSON-LD schema to homepage, add BreadcrumbList schema to blog and changelog post pages, and remove invalid SearchAction from WebSite schema.

saddlepaddle force-pushed the add-missing-canonicals-faqpage-schema-sitemap-entr branch from b1cc73a to 2cb1f21 Compare February 3, 2026 03:30

saddlepaddle temporarily deployed to preview February 3, 2026 03:30 — with GitHub Actions Inactive

saddlepaddle force-pushed the add-missing-canonicals-faqpage-schema-sitemap-entr branch from 2cb1f21 to c4e92b4 Compare February 3, 2026 04:11

saddlepaddle temporarily deployed to preview February 3, 2026 04:11 — with GitHub Actions Inactive

saddlepaddle merged commit 7379c71 into main Feb 3, 2026
13 checks passed

This was referenced Feb 3, 2026

feat(marketing): add SEO comparison pages #1160

Merged

Add team pages #1161

Merged

Kitenite deleted the add-missing-canonicals-faqpage-schema-sitemap-entr branch February 4, 2026 20:42

coderabbitai Bot mentioned this pull request Feb 18, 2026

feat(marketing): add GEO-optimized blog posts and comparison pages #1569

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(marketing): add missing canonicals, FAQPage schema, breadcrumbs, and sitemap entries#1146

fix(marketing): add missing canonicals, FAQPage schema, breadcrumbs, and sitemap entries#1146
saddlepaddle merged 1 commit intomainfrom
add-missing-canonicals-faqpage-schema-sitemap-entr

saddlepaddle commented Feb 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Feb 2, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions Bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

saddlepaddle commented Feb 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧹 Preview Cleanup Complete

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

saddlepaddle commented Feb 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Feb 2, 2026 •

edited

Loading

github-actions Bot commented Feb 3, 2026 •

edited

Loading