-
Notifications
You must be signed in to change notification settings - Fork 874
Create a worktree for each opened branch #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| import simpleGit from "simple-git"; | ||
| import { join } from "node:path"; | ||
| import { mkdir } from "node:fs/promises"; | ||
|
|
||
| export function generateBranchName(): string { | ||
| const adjectives = [ | ||
| "azure", | ||
| "crimson", | ||
| "emerald", | ||
| "golden", | ||
| "indigo", | ||
| "jade", | ||
| "lavender", | ||
| "magenta", | ||
| "navy", | ||
| "olive", | ||
| "pearl", | ||
| "rose", | ||
| "silver", | ||
| "teal", | ||
| "violet", | ||
| ]; | ||
|
|
||
| const nouns = [ | ||
| "cloud", | ||
| "forest", | ||
| "mountain", | ||
| "ocean", | ||
| "river", | ||
| "storm", | ||
| "sunset", | ||
| "thunder", | ||
| "wave", | ||
| "wind", | ||
| "meadow", | ||
| "canyon", | ||
| "glacier", | ||
| "valley", | ||
| "peak", | ||
| ]; | ||
|
|
||
| const adjective = adjectives[Math.floor(Math.random() * adjectives.length)]; | ||
| const noun = nouns[Math.floor(Math.random() * nouns.length)]; | ||
| const number = Math.floor(Math.random() * 100); | ||
|
|
||
| return `${adjective}-${noun}-${number}`; | ||
| } | ||
|
|
||
| export async function createWorktree( | ||
| mainRepoPath: string, | ||
| branch: string, | ||
| worktreePath: string, | ||
| ): Promise<void> { | ||
| try { | ||
| const parentDir = join(worktreePath, ".."); | ||
| await mkdir(parentDir, { recursive: true }); | ||
|
|
||
| const git = simpleGit(mainRepoPath); | ||
| await git.raw(["worktree", "add", worktreePath, "-b", branch]); | ||
|
|
||
| console.log(`Created worktree at ${worktreePath} with branch ${branch}`); | ||
| } catch (error) { | ||
| console.error(`Failed to create worktree: ${error}`); | ||
| throw new Error(`Failed to create worktree: ${error}`); | ||
| } | ||
| } | ||
|
|
||
| export async function removeWorktree( | ||
| mainRepoPath: string, | ||
| worktreePath: string, | ||
| ): Promise<void> { | ||
| try { | ||
| const git = simpleGit(mainRepoPath); | ||
| await git.raw(["worktree", "remove", worktreePath, "--force"]); | ||
|
|
||
| console.log(`Removed worktree at ${worktreePath}`); | ||
| } catch (error) { | ||
| console.error(`Failed to remove worktree: ${error}`); | ||
| throw new Error(`Failed to remove worktree: ${error}`); | ||
| } | ||
| } | ||
|
|
||
| export async function getGitRoot(path: string): Promise<string> { | ||
| try { | ||
| const git = simpleGit(path); | ||
| const root = await git.revparse(["--show-toplevel"]); | ||
| return root.trim(); | ||
| } catch (error) { | ||
| throw new Error(`Not a git repository: ${path}`); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential race condition between project lookup and database update.
The code finds a project at lines 42-44, then later updates it inside
db.update()at lines 47-52 by searching again byproject?.id. Between the initial lookup and the database update, the project could theoretically be deleted by another operation, making the second lookup fail silently.Additionally, at line 63, the non-null assertion
project!assumes the if/else logic is exhaustive, but if there's a logic error, this could cause a runtime error.Apply this diff to make the code more defensive:
if (project) { await db.update((data) => { const p = data.projects.find((p) => p.id === project?.id); if (p) { p.lastOpenedAt = Date.now(); } }); + // Refresh project reference after update + project = db.data.projects.find((p) => p.id === project?.id) ?? project; } else { project = { id: nanoid(), mainRepoPath, name, lastOpenedAt: Date.now(), createdAt: Date.now(), }; await db.update((data) => { data.projects.push(project!); }); } return { success: true as const, - project, + project: project!, };📝 Committable suggestion
🤖 Prompt for AI Agents