Skip to content

feat(desktop): add keyboard shortcut for settings menu#1080

Merged
Kitenite merged 2 commits into
mainfrom
shortcut-settings
Jan 31, 2026
Merged

feat(desktop): add keyboard shortcut for settings menu#1080
Kitenite merged 2 commits into
mainfrom
shortcut-settings

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Jan 31, 2026

Summary

  • Adds ⌘, (Cmd+comma on macOS, Ctrl+comma on Windows/Linux) keyboard shortcut to open the Settings screen
  • Adds "Settings..." menu item to the macOS app menu (after About, following Apple HIG)
  • Updates the Settings button tooltip to show the correct shortcut

Closes #1069

Test plan

  • Press ⌘, on macOS (or Ctrl+, on Windows/Linux) and verify Settings opens
  • Click the app menu on macOS and verify "Settings..." menu item appears with the shortcut
  • Hover over the Settings gear icon and verify the tooltip shows the correct shortcut
  • Verify the shortcut can be customized in Settings > Keyboard Shortcuts

Summary by CodeRabbit

New Features

  • Added a keyboard shortcut to quickly access Settings (Cmd+, on macOS; Ctrl+, on Windows and Linux)
  • Settings shortcut now displays in the application menu when assigned
  • Settings shortcut is categorized under Help in the available hotkeys list

✏️ Tip: You can customize this high-level summary in your review settings.

Add ⌘, (Cmd+comma on macOS, Ctrl+comma on Windows/Linux) to open the
Settings screen, following the standard macOS convention for app
preferences.

Changes:
- Add OPEN_SETTINGS hotkey definition with platform-specific defaults
- Add Settings menu item to macOS app menu (after About)
- Register hotkey handler in dashboard layout
- Update SettingsButton tooltip to show correct shortcut

Closes #1069
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

The PR introduces a new keyboard shortcut feature that enables users to open the Settings screen using ⌘, (macOS) or Ctrl+, (Windows/Linux). Changes include defining the hotkey in the shared configuration, registering it with navigation, adding a menu item with accelerator, and updating UI components to display the shortcut hint.

Changes

Cohort / File(s) Summary
Hotkey Definition
apps/desktop/src/shared/hotkeys.ts
Adds OPEN_SETTINGS hotkey entry with "meta+," default (darwin), "ctrl+," (win32/linux), labeled "Open Settings" under Help category.
Menu Integration
apps/desktop/src/main/lib/menu.ts
Introduces macOS application menu item for settings using computed accelerator via getMenuAccelerator, emits "open-settings" event on click.
Dashboard Hotkey Registration
apps/desktop/src/renderer/routes/_authenticated/_dashboard/layout.tsx
Registers OPEN_SETTINGS hotkey binding that navigates to "/settings/account" when pressed.
UI Shortcut Display
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/TopBar/components/OrganizationDropdown/OrganizationDropdown.tsx, apps/desktop/src/renderer/screens/main/components/SettingsButton/SettingsButton.tsx
Updates settings-related UI components to conditionally display DropdownMenuShortcut using new settingsHotkey and updates SettingsButton tooltip to reference OPEN_SETTINGS hotkey.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • CharlieHelps

Poem

🐰 A comma and meta, a quickened way,
To settings we bound with a hotkey today!
No more clicking through menus to find,
Just ⌘, and the settings unwind!

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a keyboard shortcut for the settings menu, which aligns with the file modifications and PR objectives.
Description check ✅ Passed The description covers all required template sections including summary, related issues, type of change (new feature), testing plan, though type of change checkbox not explicitly marked.
Linked Issues check ✅ Passed The code changes fully implement the requirement from #1069 to add a ⌘, keyboard shortcut for settings with platform-specific variants and make it accessible via the settings menu.
Out of Scope Changes check ✅ Passed All code changes are directly related to implementing the OPEN_SETTINGS keyboard shortcut feature; no extraneous modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shortcut-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Display the ⌘, shortcut next to the Settings option in the organization
dropdown menu for discoverability.
@Kitenite Kitenite merged commit 4345d65 into main Jan 31, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] shortcut for settings menu

1 participant