Skip to content

fix(slack): use validated env for Anthropic API key #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 1 commit into from
Jan 30, 2026
Merged

fix(slack): use validated env for Anthropic API key #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ jobs:
SLACK_CLIENT_ID: ${{ secrets.SLACK_CLIENT_ID }}
SLACK_CLIENT_SECRET: ${{ secrets.SLACK_CLIENT_SECRET }}
SLACK_SIGNING_SECRET: ${{ secrets.SLACK_SIGNING_SECRET }}
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
GH_APP_ID: ${{ secrets.GH_APP_ID }}
GH_APP_PRIVATE_KEY: ${{ secrets.GH_APP_PRIVATE_KEY }}
GH_WEBHOOK_SECRET: ${{ secrets.GH_WEBHOOK_SECRET }}
Expand Down Expand Up @@ -235,6 +236,7 @@ jobs:
--env SLACK_CLIENT_ID=$SLACK_CLIENT_ID \
--env SLACK_CLIENT_SECRET=$SLACK_CLIENT_SECRET \
--env SLACK_SIGNING_SECRET=$SLACK_SIGNING_SECRET \
--env ANTHROPIC_API_KEY=$ANTHROPIC_API_KEY \
--env GH_APP_ID="$GH_APP_ID" \
--env GH_APP_PRIVATE_KEY="$GH_APP_PRIVATE_KEY" \
--env GH_WEBHOOK_SECRET="$GH_WEBHOOK_SECRET" \
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/deploy-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ jobs:
SLACK_CLIENT_ID: ${{ secrets.SLACK_CLIENT_ID }}
SLACK_CLIENT_SECRET: ${{ secrets.SLACK_CLIENT_SECRET }}
SLACK_SIGNING_SECRET: ${{ secrets.SLACK_SIGNING_SECRET }}
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
GH_APP_ID: ${{ secrets.GH_APP_ID }}
GH_APP_PRIVATE_KEY: ${{ secrets.GH_APP_PRIVATE_KEY }}
GH_WEBHOOK_SECRET: ${{ secrets.GH_WEBHOOK_SECRET }}
Expand Down Expand Up @@ -139,6 +140,7 @@ jobs:
--env SLACK_CLIENT_ID=$SLACK_CLIENT_ID \
--env SLACK_CLIENT_SECRET=$SLACK_CLIENT_SECRET \
--env SLACK_SIGNING_SECRET=$SLACK_SIGNING_SECRET \
--env ANTHROPIC_API_KEY=$ANTHROPIC_API_KEY \
--env GH_APP_ID="$GH_APP_ID" \
--env GH_APP_PRIVATE_KEY="$GH_APP_PRIVATE_KEY" \
--env GH_WEBHOOK_SECRET="$GH_WEBHOOK_SECRET" \
Expand Down
4 changes: 2 additions & 2 deletions apps/api/src/app/api/integrations/slack/events/utils/run-agent/run-agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import Anthropic from "@anthropic-ai/sdk";
import type { Client } from "@modelcontextprotocol/sdk/client/index.js";
import { WebClient } from "@slack/web-api";

import { db } from "@superset/db/client";
import { integrationConnections } from "@superset/db/schema";
import { and, eq } from "drizzle-orm";
import { env } from "@/env";
import type { AgentAction } from "../slack-blocks";
import {
createSlackMcpClient,
Expand Down Expand Up @@ -186,7 +186,7 @@ Available tool prefixes:
export async function runSlackAgent(
params: RunSlackAgentParams,
): Promise<SlackAgentResult> {
const anthropic = new Anthropic();
const anthropic = new Anthropic({ apiKey: env.ANTHROPIC_API_KEY });
const actions: AgentAction[] = [];

const connection = await db.query.integrationConnections.findFirst({
Expand Down
3 changes: 2 additions & 1 deletion apps/api/src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export const env = createEnv({
GH_WEBHOOK_SECRET: z.string().min(1),
SLACK_CLIENT_ID: z.string().min(1),
SLACK_CLIENT_SECRET: z.string().min(1),
SLACK_SIGNING_SECRET: z.string().min(1),
SLACK_SIGNING_SECRET: z.string(),
ANTHROPIC_API_KEY: z.string(),
QSTASH_TOKEN: z.string().min(1),
QSTASH_CURRENT_SIGNING_KEY: z.string().min(1),
QSTASH_NEXT_SIGNING_KEY: z.string().min(1),
Expand Down
1 change: 0 additions & 1 deletion packages/trpc/src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export const env = createEnv({
NODE_ENV: z
.enum(["development", "production", "test"])
.default("development"),
ANTHROPIC_API_KEY: z.string().min(1).optional(),
BLOB_READ_WRITE_TOKEN: z.string().min(1),
POSTHOG_API_KEY: z.string(),
POSTHOG_API_HOST: z.string().url().default("https://us.posthog.com"),
Expand Down