-
Notifications
You must be signed in to change notification settings - Fork 901
Rough Mobile/Desktop Claude Code Implementation #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
29d885a
1dd495d
dadada1
e242c50
e62f1b9
c6e2e6d
91b102a
8665516
303ee09
5ce96e1
81a9207
c82a0c3
89d1e50
ad8fa50
0567342
f5e8f28
074ef1c
4633afc
61e99cf
e2b11ad
bb32e18
19a2a69
c4353b9
fe8aa54
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Git LFS tracking for large binaries (darwin-arm64 only for now) | ||
| apps/desktop/resources/bin/darwin-arm64/claude filter=lfs diff=lfs merge=lfs -text |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,6 +56,12 @@ const config: Configuration = { | |
| to: "resources/migrations", | ||
| filter: ["**/*"], | ||
| }, | ||
| // Claude Code binary - bundled for AI chat functionality | ||
| { | ||
| from: "resources/bin/${platform}-${arch}", | ||
| to: "bin", | ||
| filter: ["**/*"], | ||
| }, | ||
|
Comment on lines
+59
to
+64
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: find apps/desktop -type f -name "*download*" | head -20Repository: superset-sh/superset Length of output: 110 🏁 Script executed: cat -n apps/desktop/scripts/download-claude-binary.ts 2>/dev/null || echo "File not found at expected path"Repository: superset-sh/superset Length of output: 12524 🌐 Web query:
💡 Result: In
Supported macros relevant to platform/arch:
Also available (often useful alongside): Example: platform + arch–specific resources{
"build": {
"extraResources": [
{
"from": "resources/${os}/${arch}",
"to": "resources/native",
"filter": ["**/*"]
}
]
}
}This copies Notes:
Sources: electron-builder “Application Contents” (extraResources + FileSet) [1], electron-builder “File Macros” list and behavior [2]. 🌐 Web query:
💡 Result: electron-builder supports “file macros” (variable substitution) in several path-like config fields, including output directories and FileSet Macros you’re asking about
Put platform/arch into the output path{
"build": {
"directories": {
"output": "releases/${platform}/${arch}"
}
}
}This creates per-platform/per-arch folders under Use platform/arch in copy paths (
|
||
| ], | ||
|
|
||
| files: [ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reorder keys to satisfy dotenv-linter.
The linter expects
EXPO_PUBLIC_STREAMS_URLbeforeNEXT_PUBLIC_STREAMS_URL. Reordering will clear the warning.🔧 Suggested reorder
📝 Committable suggestion
🧰 Tools
🪛 dotenv-linter (4.0.0)
[warning] 34-34: [UnorderedKey] The EXPO_PUBLIC_STREAMS_URL key should go before the NEXT_PUBLIC_STREAMS_URL key
(UnorderedKey)
🤖 Prompt for AI Agents