Skip to content

fix(ui): add cursor-pointer to Button component#1029

Merged
Kitenite merged 1 commit intosuperset-sh:mainfrom
samuelswandi:fix/add-cursor-pointer-to-button
Jan 29, 2026
Merged

fix(ui): add cursor-pointer to Button component#1029
Kitenite merged 1 commit intosuperset-sh:mainfrom
samuelswandi:fix/add-cursor-pointer-to-button

Conversation

@samuelswandi
Copy link
Copy Markdown
Contributor

@samuelswandi samuelswandi commented Jan 28, 2026

Summary

  • Adds cursor-pointer class to the shared Button component so all buttons show pointer cursor on hover

Problem

Buttons in dialogs (and across the app) were not showing a pointer cursor on hover, making them feel unclickable.

Solution

Added cursor-pointer to the base CVA styles in packages/ui/src/components/ui/button.tsx. This fixes all buttons across the entire application.

Summary by CodeRabbit

  • Style
    • Improved button interactivity by updating the cursor display to show a pointer when hovering over buttons, enhancing visual feedback for users.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

A CSS utility class cursor-pointer was added to the button component's base styling. This styling enhancement provides visual feedback by changing the cursor appearance when users interact with buttons, without modifying the button's functional behavior.

Changes

Cohort / File(s) Summary
Button Component Styling
packages/ui/src/components/ui/button.tsx
Added cursor-pointer CSS class to buttonVariants base class for improved cursor feedback on button hover

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A cursor did twitch, a pointer so fine,
One class was whispered, the button did shine,
Now hover and click, the design's so neat,
Visual delight, the user's treat!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers the summary, problem, and solution, but lacks the required template structure including Related Issues, Type of Change, Testing, and Additional Notes sections. Complete the PR description using the required template by adding sections for Related Issues, Type of Change (mark Bug fix), Testing steps, and any Additional Notes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding cursor-pointer class to the Button component to improve UX.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite
Copy link
Copy Markdown
Collaborator

my least favorite tailwind 4 "feature". Thanks for updating @samuelswandi

@Kitenite Kitenite merged commit a3b287d into superset-sh:main Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants