Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always remove the layer from layers array, even if session is null #9

Closed
wants to merge 1 commit into from

Conversation

vincentfretin
Copy link

This closes aframevr/aframe#5197
You can merge and squash it with the commit 84b2da1 if you rebase -i next time you update threejs

@dmarcos
Copy link
Member

dmarcos commented Jan 3, 2023

Thanks so much. I leave this open. Working on r147 branch will be confusing and high chance for me to mess things up. I'll create a new branch and cherry pick this commit for a new super-three release.

@vincentfretin
Copy link
Author

I see you cherry-picked the commit in https://github.com/supermedium/three.js/commits/super-147-1

@vincentfretin vincentfretin deleted the patch-1 branch January 5, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants