Skip to content

fix: synthesize_button_up might cause crash on Linux #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: synthesize_button_up might cause crash on Linux #394

merged 1 commit into from
Aug 1, 2024

Conversation

boyan01
Copy link
Contributor

@boyan01 boyan01 commented Jul 12, 2024 •
edited by knopp
Loading

Fixes #403

https://docs.gtk.org/gdk3/struct.EventButton.html

Used for button press and button release events. The type field will be one of GDK_BUTTON_PRESS, GDK_2BUTTON_PRESS, GDK_3BUTTON_PRESS or GDK_BUTTON_RELEASE,

when event is DoubleButtonPress or TripleButtonPress, there is an panic occur.

@knopp
Copy link
Collaborator

knopp commented Jul 24, 2024

Are you able to trigger the crash?

@boyan01
Copy link
Contributor Author

boyan01 commented Jul 28, 2024

Are you able to trigger the crash?

Yes, Simply right-clicking the area repeatedly and quickly will reproduce the crash.

@knopp knopp mentioned this pull request Jul 31, 2024
Closed
@knopp knopp merged commit 7eb1237 into superlistapp:main Aug 1, 2024
8 checks passed
@knopp
Copy link
Collaborator

knopp commented Aug 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[super_context_menu] Crash on Linux when right-clicking quickly
2 participants
@boyan01 @knopp