Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header tag if clientId is null #32

Closed
wants to merge 1 commit into from

Conversation

anashalb
Copy link

@anashalb anashalb commented Nov 1, 2016

If clientId is null during Portal Login, the header tag will not be added around LoginScopeHeader. The request therefore errors out.

@superfell
Copy link
Owner

Thanks for this, however i think a better fix would in ZKEnvelope to have the various writeHeader methods always call moveToHeaders.

@superfell
Copy link
Owner

Thanks for flagging this, i fixed it a slightly different way, and added a test in 04a2617

@superfell superfell closed this Nov 3, 2016
@anashalb
Copy link
Author

anashalb commented Nov 3, 2016

Awesome, thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants