added some helper functions to do asynchronous SOQL and SOSL queries. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As it has no state, you could make it a category on ZKSforceClient, that way you don't need to pass one in, and you can call the new methods directly on an instance of the client object. |
|
I like. Added them directly to zkSforceClient, or would you prefer a category? |
|
I think a category would be cleaner. |
|
Sorry for all the back and forth, can you fix the header comment/license to be BSD, and collapse this down into a single change ? Thanks! |
|
doh, sorry, see you already fixed the headers. |
superfell
added a commit
that referenced
this pull request
Nov 24, 2011
added some helper functions to do asynchronous SOQL and SOSL queries.
|
Whoops, just finished the squash/rebase and I see now you already did the pull. Thanks! Happy to have contributed to something that helped me out a great deal :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the work on a background thread via
dispatch_async. I am not particularly crazy about having to pass in the current sharedzkSforceClientobject, but it seemed the simplest option short of constructing scaffolding (a singleton?) for managing a shared client app-wide. Open to better suggestions!