Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linting error in templates/ingress.yaml in the helm agent chart #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paulbehrisch
Copy link

@paulbehrisch paulbehrisch commented Nov 25, 2024

Issue

Linting fails if ingress is enabled

❯ helm lint . -f values.yaml
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/ingress.yaml: unable to parse YAML: invalid Yaml document separator: apiVersion: networking.k8s.io/v1

Error: 1 chart(s) linted, 1 chart(s) failed

How to reproduce

  • git clone the repo and checkout the main branch
  • cd agent/helm/agent
  • set agentKey, agentHostUrl and agentDataDomain in values.yaml
  • Enable ingress in values.yaml
ingress: 
   enabled: true
  • Run helm lint . -f values.yaml
Output
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/ingress.yaml: unable to parse YAML: invalid Yaml document separator: apiVersion: networking.k8s.io/v1

Error: 1 chart(s) linted, 1 chart(s) failed

Fix

  • Update templates/ingress.yaml with the change in the PR
  • Run lint again to verify
❯ helm lint . -f values.yaml
==> Linting .
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paulbehrisch paulbehrisch changed the title fix linting error in templates/ingress.yaml fix linting error in templates/ingress.yaml in the helm agent chart Nov 25, 2024
@paulbehrisch paulbehrisch marked this pull request as ready for review November 25, 2024 04:00
@@ -61,7 +61,7 @@ spec:
{{- end }}
{{- end }}
---
{{- $grpcPort := .Values.service.ports.grpc -}}
{{ $grpcPort := .Values.service.ports.grpc -}}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found another project had the same problem

@paulbehrisch
Copy link
Author

Is there any update on this?

@taha-au
Copy link
Contributor

taha-au commented Feb 18, 2025

sorry for the delay on the reply @paulbehrisch. could you sign the CLA? #295 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants