Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auth0 wrapper #183

Merged
merged 44 commits into from
Dec 8, 2023
Merged

feat: add auth0 wrapper #183

merged 44 commits into from
Dec 8, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Oct 26, 2023

What kind of change does this PR introduce?

POC around an auth0 wrapper for continuous migration from Auth0 to Supabase Auth. Done as a side project.

We currently support only the users page. Similar to the Stripe FDW more objects can be added via the options table. For the moment, we only support the key fields from users (e.g. identities, email, email_verified) though more can be added upon request.

CleanShot 2023-11-22 at 10 22 02@2x

Not too familar with Rust so will ask in advance for the patience of reviewers when reviewing this PR 🙏

  • Mock server + tests
  • Refactor to align with qdrant_fdw structure

wrappers/src/fdw/auth0_fdw/auth0_client/mod.rs Outdated Show resolved Hide resolved
wrappers/src/fdw/auth0_fdw/auth0_client/rows_iterator.rs Outdated Show resolved Hide resolved
wrappers/src/fdw/auth0_fdw/result.rs Outdated Show resolved Hide resolved
@J0 J0 marked this pull request as ready for review November 22, 2023 02:24
@J0 J0 requested review from burmecia and imor November 24, 2023 11:14
wrappers/src/fdw/auth0_fdw/auth0_fdw.rs Outdated Show resolved Hide resolved
@burmecia
Copy link
Member

burmecia commented Dec 5, 2023

Can you upgrade Rust to v1.74.0 and remove warnings outputted by cargo clippy --features auth0_fdw?

@J0
Copy link
Contributor Author

J0 commented Dec 5, 2023

patched the warnings but still need to refactor the codebase as a whole. Will try to find time for it this evening or tomorrow morning

@J0
Copy link
Contributor Author

J0 commented Dec 7, 2023

Getting closer, but might need a bit more time to consult about the deserialization + pagination

@J0
Copy link
Contributor Author

J0 commented Dec 8, 2023

As discussed will merge for now and address

  1. reinstate the statistics
  2. Add proper logic around have_more_rows and next_page_offset
  3. Add all relevant fields

in a follow up PR. As a stretch we will also add support for other objects and push down qualifiers/search queries which involve multiple objects.

Very appreciative of @imor for help with pushing this first piece through. Thanks so much!

@J0 J0 merged commit 0061b16 into main Dec 8, 2023
2 checks passed
@J0 J0 deleted the j0/add_auth0_wrapper branch December 8, 2023 14:58
@J0 J0 mentioned this pull request Dec 10, 2023
kamyshdm pushed a commit to dymium-io/supabase-wrappers that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants