-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for qdrant foreign data wrapper #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imor
requested review from
burmecia and
olirice
and removed request for
burmecia
September 26, 2023 13:08
olirice
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*On Hold until Oct 14
imor
changed the title
add support for qdrant foreign data wrapper
feat: add support for qdrant foreign data wrapper
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a foreign data wrapper for qdrant vector database. This is a bare-bones version only supporting simple select statements which returns data from the Qdrant's scroll points endpoint. For more information about how the wrapper works, read the docs in the PR.
Implementation wise, this wrapper is quite similar to others in design in that we call the
collection/<collection_name>/points/scroll
api with appropriate parameters in the wrapper callbacks and return that data in a form Postgres is happy with. One slight improvement is that we run the query in batches so as to not balloon the memory used by the wrapper. The default batch size is currently hardcoded to 1000.