feat: return Row from iter_scan instead of mutating in-place #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
iter_scan
method signature fromfn iter_scan(&mut self, row: &mut Row) -> Result<Option<()>, E>
tofn iter_scan(&mut self) -> Result<Option<Row>, E>
. The new signature is better in that the user is forced to return aRow
instead of updating the incoming row in-place, which they can forget.