-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fallible ForeignDataWrapper trait methods #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmecia
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
imor
changed the title
Fallible ForeignDataWrapper trait methods
chore: fallible ForeignDataWrapper trait methods
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring
What is the current behavior?
The
ForeignDataWrapper
trait's methods do not returnResult
s even though they are fallible. This results in forcing the user to callunwrap
orexpect
, instead of the more ergonomic alternative of returning anErr
.What is the new behavior?
The
ForeignDataWrapper
trait's methods will now return aResult
. The error types should be convertible into anErrorReport
, i.e. they shouldimpl From<ErrorType> for ErrorReport
for the FDW'sErrorType
. AnErrorReport
is apgrx
type to represent errors which can be reported to Postgres. The errors returned by the trait's methods will be automatically reported to Postgres by thesupabase-wrappers
framework.An example FDW with the new API looks something like this:
Additional context
This impl is similar to but not exactly the same as suggested in #81. The major difference is the there is no
WrappersError
but instead each FDW can define it's own error type. A type similar toWrappersError
can be introduced later if needed.This PR just lays the groundwork for all FDWs to better report and handle errors. But the FDWs haven't been updated with this PR. They will be done in separate, later PRs.