Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Only a file rename.
What is the current behavior?
The
.test/select-query-parser/default-inference-d.ts
file is not checked bytsd
, because its name does not match the specified pattern:postgrest-js/package.json
Line 43 in 0af65f5
You can proof this by adding a failing assertion to the file and running
npm run test:types
. The error is not reported.What is the new behavior?
Renaming the file to
./test/select-query-parser/default-inference.test-d.ts
makes sure it is picked up bytsd
.Additional context
Unfortunately
tsd
does not print names of test files. That makes it very easy to make similar mistakes.