Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename type test file #579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrazauskas
Copy link

@mrazauskas mrazauskas commented Nov 23, 2024

What kind of change does this PR introduce?

Only a file rename.

What is the current behavior?

The .test/select-query-parser/default-inference-d.ts file is not checked by tsd, because its name does not match the specified pattern:

"test:types": "run-s build && tsd --files 'test/**/*.test-d.ts'",

You can proof this by adding a failing assertion to the file and running npm run test:types. The error is not reported.

What is the new behavior?

Renaming the file to ./test/select-query-parser/default-inference.test-d.ts makes sure it is picked up by tsd.

Additional context

Unfortunately tsd does not print names of test files. That makes it very easy to make similar mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant