-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass fetch options while building the query #527
Open
g12i
wants to merge
13
commits into
supabase:master
Choose a base branch
from
g12i:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g12i
commented
Mar 23, 2024
Instead of this being Next.js specific, not sure if it might be better to just allow customization of any |
Yeah, I agree @bnjmnt4n. Let me make a quick update |
g12i
changed the title
Allow to pass Next.js options to fetch while building query
Allow to pass fetch options while building query
Apr 2, 2024
g12i
changed the title
Allow to pass fetch options while building query
Allow to pass fetch options while building the query
Apr 3, 2024
Hello @soedirgo, any chance this gets reviewed? |
@soedirgo bump :P |
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This adds a possibility to pass any fetch options (e.g.
next
options to fetch while building the query.What is the current behavior?
Currently we can pass fetch at
PostgrestBuilder
creation. Which effectively means once, if using Supabase. One would have to parse URL and alter options depending on the URL. E.g. for passingnext.tags
optionsWhat is the new behavior?
Allow to pass
fetchOptions
options when building query. The idea here isBecause FetchOptions include
signal
, it is marked as deprecated and uses.fetchOptions
internally.