Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated SQL: Timed out responses are no longer recorded as "SUCCESSFUL" #93

Merged
merged 1 commit into from
May 20, 2023
Merged

Updated SQL: Timed out responses are no longer recorded as "SUCCESSFUL" #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/pg_net.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,15 +305,15 @@ begin
from net._http_response
where id = request_id;

if rec is null then
if rec is null or rec.error_msg is not null then
-- The request is either still processing or the request_id provided does not exist

-- TODO: request in progress is indistinguishable from request that doesn't exist

-- No request matching request_id found
return (
'ERROR',
'request matching request_id not found',
coalesce(rec.error_msg, 'request matching request_id not found'),
null
)::net.http_response_result;

Expand Down