Fix malformed headers #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tempted to use this newish (2022) curl feature for parsing the headers: https://curl.se/libcurl/c/curl_easy_nextheader.html (announcement). It's pretty convenient. It's available from curl 7.83, I believe now that we have Nix on prod it should be doable to get this version. Note: We need to document this requirement on the README. We might solve this as well #115 |
steve-chavez
force-pushed
the
fix-malformed
branch
from
82243d8
to
d5c8714
Compare
This comment was marked as outdated.
This comment was marked as outdated.
- Now libcurl >= 7.83 is a requirement - Tests are changed to fit new libcurl behavior
steve-chavez
force-pushed
the
fix-malformed
branch
from
d5c8714
to
2303382
Compare
soedirgo
approved these changes
Aug 8, 2024
pashkinelfe
reviewed
Aug 8, 2024
| worker.bgw_main_arg = (Datum) 0; | ||
| worker.bgw_notify_pid = 0; | ||
| RegisterBackgroundWorker(&worker); | ||
| RegisterBackgroundWorker(&(BackgroundWorker){ |
There was a problem hiding this comment.
IMO previous state of pg_init() was completely ok and also was easier to read.
There was a problem hiding this comment.
The new way using C99 designated initializer requires fewer LOC and avoids the need to memset to 0. Readability is highly subjective but fewer LOCs in this case is a win IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a malformed header such as:
The background worker crashes.
To prove the above, we use https://github.com/steve-chavez/ngx_pathological.