Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Configuration variables list to documentation #112

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

TheOtherBrian1
Copy link
Contributor

What kind of change does this PR introduce?

Docs Update

What is the current behavior?

The documentation does not reference all the config variables.

Please link any relevant issues here:
Solves the primary complaint of of ISSUE #97

What is the new behavior?

The documentation outlines the configuration variables and how to update them.

Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheOtherBrian1 Great work! 💯

@steve-chavez steve-chavez merged commit 4c5eb5b into supabase:master Oct 18, 2023
5 checks passed
Comment on lines +158 to +165
You can change the variables by adding any of the following line to your postgres.conf file
```
pg_net.batch_size = <new integer>
pg_net.ttl = '<new ttl interval>'
pg_net.database_name = '<database name>'
```

After saving the file, you can execute `SELECT pg_reload_conf()` to update _postgres.conf_ for your database. If the extension does not respond to the update, it may be necessary to restart your database.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheOtherBrian1 By any chance did you tried doing this on Supabase? Or do you self host?

I think on Supabase right now you can't do ALTER SYSTEM .. plus pg_reload_conf() since they require superuser.

Copy link
Contributor Author

@TheOtherBrian1 TheOtherBrian1 Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on a self hosted instance. I just ran the following SQL to see how Supabase would react:

ALTER SYSTEM SET pg_net.batch_size = 200;

It gave an error:

Error running SQL: Failed to run sql query: permission denied to set parameter "pg_net.batch_size"

Through Supabase's CLI, it is possible to override some config variables, but the permitted list does not extend to PG_NET.

I'll add a caveat to the documentation that configuration is only possible on self-hosted instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants