feat: support storage s3 protocol config #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sweatybridge my setup got broken by this change. I like the idea, of making it explicit but a minor version bump with a breaking change in the config is not so nice. |
Contributor
Author
|
Thanks for letting me know and sorry about the breaking change. I will definitely take note for future changes. I can also revert to enabling s3 protocol by default if that helps. |
|
I got it fixed so not a problem for me, i hope it will not break others too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the new behavior?
Enable s3 protocol via config as code.
Additional context
Add any other context or screenshots.