Skip to content

Conversation

@sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 21, 2025

What kind of change does this PR introduce?

Bug fix #3684 (comment)

What is the new behavior?

Allow library users to override config after loading from file.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner October 21, 2025 12:31
@coveralls
Copy link

coveralls commented Oct 21, 2025

Pull Request Test Coverage Report for Build 18685816705

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 54.579%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 80.61%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 18675400641: -0.03%
Covered Lines: 6389
Relevant Lines: 11706

💛 - Coveralls

@sweatybridge sweatybridge changed the title fix: allow defining empty env var fix: ignore missing ssl paths error Oct 21, 2025
@sweatybridge sweatybridge changed the title fix: ignore missing ssl paths error fix: allow overriding config after load Oct 21, 2025
@sweatybridge sweatybridge merged commit 886a008 into develop Oct 21, 2025
11 checks passed
@sweatybridge sweatybridge deleted the pkg-mod branch October 21, 2025 13:45
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to provide custom self signed certificates

3 participants