Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip version check if user is offline #2498

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jul 6, 2024

What kind of change does this PR introduce?

Bug fix #2470

What is the new behavior?

If user is offline, version check will error and an empty file will be created to skip subsequent checks.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner July 6, 2024 14:56
@coveralls
Copy link

coveralls commented Jul 6, 2024

Pull Request Test Coverage Report for Build 9820118668

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 61.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/root.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
internal/utils/release.go 1 76.19%
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 9820042589: -0.03%
Covered Lines: 7126
Relevant Lines: 11622

💛 - Coveralls

@sweatybridge sweatybridge merged commit 2016b7a into develop Jul 6, 2024
9 checks passed
@sweatybridge sweatybridge deleted the off-check branch July 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting started with CLI does not work (start, login)
2 participants