Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make dependent service schemas optional #2497

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jul 6, 2024

What kind of change does this PR introduce?

Bug fix #2407

What is the new behavior?

Don't initialise auth, storage, or realtime schemas if those services are disabled.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner July 6, 2024 14:09
@coveralls
Copy link

coveralls commented Jul 6, 2024

Pull Request Test Coverage Report for Build 9819857393

Details

  • 78 of 78 (100.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 61.323%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 9811516760: 0.09%
Covered Lines: 7127
Relevant Lines: 11622

💛 - Coveralls

@sweatybridge sweatybridge merged commit fef048f into develop Jul 6, 2024
9 checks passed
@sweatybridge sweatybridge deleted the opt-schema branch July 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't download excluded container images
2 participants