Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn use of getSession() when isServer on storage #846

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Jan 20, 2024

Warn about using getSession() when the storage has isSever to true without previously having called getUser().

Warn each time the user is accessed as returned by getSession().

Relates to:

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@hf hf merged commit 9ea94fe into master Feb 4, 2024
2 checks passed
@hf hf deleted the hf/storage-is-server branch February 4, 2024 15:37
kangmingtay pushed a commit that referenced this pull request Mar 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.63.0](v2.62.2...v2.63.0)
(2024-03-26)


### Features

* add method for anonymous sign-in
([#858](#858))
([e8a1fc9](e8a1fc9))
* add support for error codes
([#855](#855))
([99821f4](99821f4))
* explicit `cache: no-store` in fetch
([#847](#847))
([034bee0](034bee0))
* warn use of `getSession()` when `isServer` on storage
([#846](#846))
([9ea94fe](9ea94fe))


### Bug Fixes

* refactor all pkce code into a single method
([#860](#860))
([860bffc](860bffc))
* remove data type
([#848](#848))
([15c7c82](15c7c82))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@j4w8n j4w8n mentioned this pull request Apr 5, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants