New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace asserts with appropriate exceptions. #24

Merged

BrianPugh merged 3 commits into master from remove-asserts

Dec 15, 2024

Collaborator

BrianPugh commented Dec 15, 2024 •

edited

Loading

Replace assert calls to ValueError.
Added a unit test for dice2h and h2dice.
Rename asserts folder to assets.
Fix some image artifacts in assets/demo_cube.png

BrianPugh added 3 commits

December 15, 2024 10:43


          replace asserts/NotImplementedError in c2e with ValueError


          rename assert folder to assets

5e72d2c


          replace all asserts with appropriate ValueErrors.

25449ea

BrianPugh merged commit cc2b90d into master

0 of 15 checks passed

BrianPugh deleted the remove-asserts branch

December 15, 2024 18:01

BrianPugh mentioned this pull request

Upcoming Release v1.0.0 #32

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet