Postgres 18 OAuth #340
Draft
Postgres 18 OAuth #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
reviewed
Oct 30, 2025
| // TODO: include the oauth mechanism, but I am not sure if the state should still be | ||
| // ScramClientFirstReceived. when I am respomding with the SASLInitialResponse, I have to include the `auth` | ||
| // field. that means I have to check if the selected mechanism is oauth, then construct the SASLInitialResponse. | ||
| // then, I'll handle the AuthenticationSASLContinue message type (add it to the PasswordMessageFamily enum) |
There was a problem hiding this comment.
add it to the PasswordMessageFamily enum
The reason we have PasswordMessageFamily enum is because all these types shares the same type code p. We already have AuthenticationSASLCcontinue in Authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.