-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/serde feature #53
Conversation
This feature is almost down except an example for serde, that works on both stable and nightly channel. |
After testing this locally, I now have this new serde_json feature running successfully with my local fork of handlebars-iron, so I can confirm this is working fine :-) |
@sorenhoyer Are you on nightly or stable? I'm on nightly and blocked by an upstream (quasi_macros) failure for now. |
sorenhoyer@24b9e79 - this seems to solve the quasi_macros compile error, and lets the tests run using "cargo test --features serde_type --no-default-features" (tested on nightly, doesn't have stable installed on my pc) |
@sorenhoyer thanks! I will try |
unfortunately I'm getting even more errors with |
b92fde7
to
07ff24e
Compare
There have recently been some changes to rustc which broke multiple projects in the @serde-rs organization (see serde-deprecated/quasi#26 for example). I am using serde successfully with I've also been experimenting a little bit with this branch and so far it's working great! |
@sunng87 just it does work on rustc 1.7.0-nightly (b4707ebca 2015-12-27). If they've made breaking changes once again I guess we'll have to wait a little longer while the rust ecosystem matures a bit :/ What errors did you get? |
@TimNN @sorenhoyer thanks for your investigation! I will wait until serde crates are back to normal. Interesting that most rust developers are still on nightlies even after half a year of stable release. |
We are almost there! I can compile and run the example on nightly 2016-01-03. But it seems the latest nightly breaks |
b201184
to
3b74852
Compare
Oh I finally get these tests passed! Will merge this soon. |
Cool. Great job. Thanks! |
This feature has been released in 0.13.0. Let me know if there is any issue with it. Document is coming soon. |
Fixes #50
Added a feature flag to use serde_json as type system, while keeping rustc_serialize as default implementation. Backward compatible.