Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/serde feature #53

Merged
merged 16 commits into from
Jan 14, 2016
Merged

Feature/serde feature #53

merged 16 commits into from
Jan 14, 2016

Conversation

sunng87
Copy link
Owner

@sunng87 sunng87 commented Dec 16, 2015

Fixes #50

Added a feature flag to use serde_json as type system, while keeping rustc_serialize as default implementation. Backward compatible.

@sunng87
Copy link
Owner Author

sunng87 commented Dec 25, 2015

This feature is almost down except an example for serde, that works on both stable and nightly channel.

@sorenhoyer
Copy link

After testing this locally, I now have this new serde_json feature running successfully with my local fork of handlebars-iron, so I can confirm this is working fine :-)

@sunng87
Copy link
Owner Author

sunng87 commented Dec 30, 2015

@sorenhoyer Are you on nightly or stable? I'm on nightly and blocked by an upstream (quasi_macros) failure for now.

https://travis-ci.org/sunng87/handlebars-rust/jobs/98979548

sorenhoyer pushed a commit to sorenhoyer/handlebars-rust that referenced this pull request Jan 3, 2016
@sorenhoyer
Copy link

sorenhoyer@24b9e79 - this seems to solve the quasi_macros compile error, and lets the tests run using "cargo test --features serde_type --no-default-features"

(tested on nightly, doesn't have stable installed on my pc)

@sunng87
Copy link
Owner Author

sunng87 commented Jan 5, 2016

@sorenhoyer thanks! I will try default-features=false on serde_codegen

@sunng87
Copy link
Owner Author

sunng87 commented Jan 5, 2016

unfortunately I'm getting even more errors with default-features turned off on serde_codegen. I'm on nightly 2016-01-03

@TimNN
Copy link
Contributor

TimNN commented Jan 5, 2016

There have recently been some changes to rustc which broke multiple projects in the @serde-rs organization (see serde-deprecated/quasi#26 for example).

I am using serde successfully with nightly-2015-12-28 in another project of mine, so this should work here too.

I've also been experimenting a little bit with this branch and so far it's working great!

@sorenhoyer
Copy link

@sunng87 just it does work on rustc 1.7.0-nightly (b4707ebca 2015-12-27). If they've made breaking changes once again I guess we'll have to wait a little longer while the rust ecosystem matures a bit :/ What errors did you get?

@sunng87
Copy link
Owner Author

sunng87 commented Jan 6, 2016

@TimNN @sorenhoyer thanks for your investigation! I will wait until serde crates are back to normal.

Interesting that most rust developers are still on nightlies even after half a year of stable release.

@sunng87
Copy link
Owner Author

sunng87 commented Jan 7, 2016

We are almost there! I can compile and run the example on nightly 2016-01-03. But it seems the latest nightly breaks rand crate again.

@sunng87
Copy link
Owner Author

sunng87 commented Jan 13, 2016

Oh I finally get these tests passed! Will merge this soon.

sunng87 added a commit that referenced this pull request Jan 14, 2016
@sunng87 sunng87 merged commit 54f80b7 into master Jan 14, 2016
@sorenhoyer
Copy link

Cool. Great job. Thanks!

@sunng87
Copy link
Owner Author

sunng87 commented Jan 15, 2016

This feature has been released in 0.13.0. Let me know if there is any issue with it.

Document is coming soon.

@sunng87 sunng87 deleted the feature/serde-feature branch January 15, 2016 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants