fix: invalid window id errors #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same errors when using shade with Nvim-R Plugin |
|
@gwd999 are those errors solved with this PR? |
|
I have the same issue with rmagatti/auto-session. Does this plugin need to be handled separately or will this PR also cover that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks a lot for this plugin! I've run into the 'invalid window id' errors reported in #4 and #16 (and maybe also #2). In this PR I've solved them (as far as I can tell) by simply checking whether the window ids are valid before attempting to do anything with them. Let me know if this is useful to the plugin or if you'd like me to improve it in some way.
Given that it's just checking for the validity of the window ids, I don't think it should make anything worse at least :).
[EDIT: If anyone reading this wants a somewhat useable fork, feel free to check out mine. It's got all PRs from the original repo merged and some additional fixes.
EDIT2: I now use tint.nvim instead and stopped maintaining the fork.]