Skip to content

Conversation

@jorgecarleitao
Copy link
Contributor

Re-activated the test that performs multiple random sorts and compares against std's sort.

I decreased the size of of the arrays to keep the tests fast. I think that the test is really useful. Related to apache/arrow#9602 .

@codecov-io
Copy link

Codecov Report

Merging #2 (105b7eb) into master (f663e81) will increase coverage by 1.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   80.39%   81.89%   +1.50%     
==========================================
  Files           1        1              
  Lines         102      116      +14     
==========================================
+ Hits           82       95      +13     
- Misses         20       21       +1     
Impacted Files Coverage Δ
src/lib.rs 81.89% <100.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f663e81...105b7eb. Read the comment docs.

@sundy-li
Copy link
Owner

sundy-li commented Mar 7, 2021

I commented on it because I don't want to introduce the rand crate.
I did not find the way to make rand only work in dev-dependencies.
My IDE suggested me to add crate rand.

At last, I found there is an option.

edition = "2018"

@sundy-li sundy-li merged commit 4b1339b into sundy-li:master Mar 7, 2021
@sundy-li
Copy link
Owner

sundy-li commented Mar 8, 2021

I just noticed the miri test is failed. But no detailed error logs, is that issue about partial_sort or miri? The miri tests time is nearly 2 hours, maybe it's killed by Github workflow.

running 5 tests
test tests::empty_test ... ok
test tests::single_test ... ok
error: test failed, to rerun pass '--lib'

Caused by:
  process didn't exit successfully: `/usr/share/rust/.rustup/toolchains/nightly-2021-01-19-x86_64-unknown-linux-gnu/bin/cargo-miri /home/runner/work/partial_sort/partial_sort/target/x86_64-unknown-linux-gnu/debug/deps/partial_sort-bf79b09649087c3d --nocapture` (exit code: 255)
make: *** [Makefile:5: miri] Error 255
test tests::sorted_random_u64_test ... 
Error: Process completed with exit code 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants