Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] try simple scalar #77

Closed

Conversation

andylokandy
Copy link

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #issue

Copy link

Pull request description must contain CLA like the following:

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

## Summary

Summary about this PR

- Close #issue

Copy link

This pull request's title is not fulfill the requirements. @andylokandy please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

Copy link

what-the-diff bot commented Jan 19, 2024

PR Summary

  • Reduction of Clutter within the Code
    This PR thoroughly cleaned up the file src/query/expression/src/converts/meta/index_scalar.rs. We removed a number of redundant imports and unused types and structs, making this file easier to read and maintain.

  • Simplified Data Structures
    We modified key data structures (IndexScalar, IndexColumn). This simplification was done through the elimination of several variant matches and type conversions that were found to be unnecessary for the function of the program.

  • Removal of Unused Implementations
    Several unused implementations for conversion methods and operations like serialize, deserialize, eq, and PartialEq on IndexColumn have also been removed.

  • Elimination of Extraneous Comments
    We have removed various unnecessary comments within the code to increase its readability.

The main aim of these changes is to make the code more maintainable and easier to work with by eliminating elements that are obsolete or unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant