Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash reports SDK #33

Closed
asa47 opened this issue Feb 20, 2017 · 4 comments
Closed

Crash reports SDK #33

asa47 opened this issue Feb 20, 2017 · 4 comments
Labels
bug

Comments

@asa47
Copy link

asa47 commented Feb 20, 2017

Hello guys,
We received some crash reports, could you please help us investigating the cause of the issue?
We had four occurrences in the last week, and I am trying to understand if it is caused by us or it is from the SDK.

The following is the crash summary:
LOCATION: [SMPBluetoothManager connectToReader:hasBeenRetrieved:updateBlock:]
EXCEPTION: NSInternalInconsistencyException
MESSAGE: Invalid parameter not satisfying: peripheral != nil
LAST INTERACTION: Display SMPPaymentCardReaderVC

Thanks!
@mollidor
Copy link
Contributor

Hi.

Thanks a lot for the report. We'll look into it asap. We'll let you know as soon as we have a fix.

Which SDK version are you currently on?
Can you give us a hint to what state the reader was in before your last interaction?
Was it already awake or did you expect the SDK to wake it up?
Did you do a transaction before or did it happen on the first tx after app launch?

Thanks a lot for your help and sorry for the inconvenience caused.

Regards,
Lukas

@mollidor mollidor added the bug label Feb 20, 2017
@asa47
Copy link
Author

asa47 commented Feb 20, 2017

Hello Lukas,

Thanks for the quick reply, and we are currently on the 2.1 version of the SDK.
Unfortunately, we do not know in which status was the reader, we received those crashes from our customers. We tried to replicate the crashes in our development office but we had no luck.

Let me know, if you find something.
Thanks a lot!

mollidor added a commit that referenced this issue Mar 24, 2017
@mollidor
Version 2.2: Add method to prepare a checkout
452e1ea 
* [BUGFIX] Fix a crash when trying to re-connect to an Air/PIN+ terminal,
  see [issue #33](#33)
* [ADDED] Add `+[SumupSDK prepareForCheckout]` to prepare the SDK when
  a checkout attempt is imminent.
* [ADDED] Add `+[SumupSDK testSDKIntegration]` to validate your
  integration. Please do not call in Release builds but only in
  development.
* [IMPROVEMENT] Speed up wake on Bluetooth
* [IMPROVEMENT] Fix an issue where subsequent checkout attempts would
  keep failing when BT connection to Air/PIN+ Terminal has been lost
  during checkout

Sample application:

* [ADDED] Tapping "Next" on the keyboard when entering an amount will
  wake a connected terminal by calling `+[SumupSDK prepareForCheckout]`.
* [ADDED] Run `+[SumupSDK testSDKIntegration]` when building in
  Debug configuration.
mollidor added a commit that referenced this issue Mar 24, 2017
@mollidor
Version 2.2-miura: Add method to prepare a checkout
bcc183b 
This version of the SDK supports the Miura card readers M006 and M010 in
addition to SumUp's proprietary card terminals.
If you do not plan to support Miura readers, please keep using the
release/preview versions of the SDK which do not support these readers.

* [BUGFIX] Fix a crash when trying to re-connect to an Air/PIN+ terminal,
  see [issue #33](#33)
* [ADDED] Add `+[SumupSDK prepareForCheckout]` to prepare the SDK when
  a checkout attempt is imminent.
* [ADDED] Add `+[SumupSDK testSDKIntegration]` to validate your
  integration. Please do not call in Release builds but only in
  development.
* [IMPROVEMENT] Speed up wake on Bluetooth
* [IMPROVEMENT] Fix an issue where subsequent checkout attempts would
  keep failing when BT connection to Air/PIN+ Terminal has been lost
  during checkout

Sample application:

* [ADDED] Tapping "Next" on the keyboard when entering an amount will
  wake a connected terminal by calling `+[SumupSDK prepareForCheckout]`.
* [ADDED] Run `+[SumupSDK testSDKIntegration]` when building in
  Debug configuration.
@mollidor
Copy link
Contributor

Hi @asa47

Would you mind giving v2.2 a try? We believe this issue is fixed. Feel free to re-open if needed.

Kind regards,
Lukas

@fetzig
Copy link

fetzig commented May 23, 2018 •
edited
Loading

@mollidor has not been fixed. got a crash report in yesterday.

sdk version 3.0
iPad mini with iOS 9.3.5
memory on device was low (8mb free). maybe that helps.

seems like i can't reopen myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fetzig @mollidor @asa47