Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSKeychain class in SumUp SDK breaks iOS 10 #15

Closed
ls-david-clerc opened this issue Aug 2, 2016 · 4 comments
Closed

SSKeychain class in SumUp SDK breaks iOS 10 #15

ls-david-clerc opened this issue Aug 2, 2016 · 4 comments

Comments

@ls-david-clerc
Copy link

Hi,

Apparently SumUp's SDK declares a class called SSKeychain which is in conflict with the system one. This is causing us issues with key chain functions (i.e. our app doesn't work when compiled for iOS 10).

Could you remove this class from your SDK ?

objc[67397]: Class SSKeychain is implemented in both /Users/xx/Downloads/Xcode-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/System/Library/PrivateFrameworks/StoreServices.framework/StoreServices (0x11752d490) and /Users/xx/Library/Developer/CoreSimulator/Devices/169BEXXX-11CC-41B7-AAD7-86A3A2C9B58E/data/Containers/Bundle/Application/E8F77XXX-4EEC-4D4F-B9B9-A6E7EB75C85E/xx.app/xxApp (0x1060ecf00). One of the two will be used. Which one is undefined.
@mollidor
Copy link
Contributor

mollidor commented Aug 2, 2016

thanks for the report. We'll look into it.

mollidor added a commit that referenced this issue Aug 3, 2016
@mollidor
1.3.0b4: Fix issues with C&S transactions and avoid collisions on iOS 10
96487d9 
* [BUGFIX] Fix an issue where some C&S transactions would
           incorrectly be reported as failed

* [IMPROVEMENT] Improve BTLE discovery of the new SumUp terminal
* [IMPROVEMENT] Prefix some internal classes to avoid collisions,
                see #15.

Sample application:

* [IMPROVEMENT] Remove `-w` in other linker flags and hint from README.
@mollidor
Copy link
Contributor

mollidor commented Aug 3, 2016

Hi @dclerc .

We've just released 1.3.0b4 which hopefully fixes your issue. Would you mind giving it a try and let us know? https://github.com/sumup/sumup-ios-sdk/tree/develop

Thanks,
Lukas

@ls-david-clerc
Copy link
Author

It works, thanks!

@mollidor
Copy link
Contributor

mollidor commented Aug 4, 2016

Thanks for raising it. Please keep in mind to add NSBluetoothPeripheralUsageDescription to your info plist when building on iOS 10 as it will crash if not present and firing up BTLE.

See https://developer.apple.com/library/mac/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html#//apple_ref/doc/uid/TP40009251-SW20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ls-david-clerc @mollidor