Update webpack-encore.rst #786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the missing step to install StimulusBundle. Onwards it talks about e.g. assets/bootstrap.js assets/controllers.json assets/controllers/hello_controller.js Which is from the StimulusBundle :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing step to install StimulusBundle.
Onwards it talks about e.g.
assets/bootstrap.js
assets/controllers.json
assets/controllers/hello_controller.js
Which is from the StimulusBundle :)
What's in this PR?
The guide explains steps of the StimulusBundle, but does not mention installing it.
Why?
Well.. if you strictly follow the guide. You won't find most of the files mentioned. e.g.
assets/bootstrap.js
assets/controllers.json
assets/controllers/hello_controller.js
and the change in the webpack about Stimulus.