Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added short title to fields #6

Merged
merged 16 commits into from
Nov 17, 2016

Conversation

rs2487
Copy link
Contributor

@rs2487 rs2487 commented Nov 15, 2016

fixes #3

@alexander-schranz
Copy link
Member

@rs2487 pls rebase and squash the commits

<input id="short-title<~=index~>"
data-property="shortTitle"
type="text"
class="form-element preview-update trigger-save-button"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add maxlength attribute where it is limited in the database


<div class="block-content" data-sort-mode-id="{{ blockId }}shortTitle<~=index~>"></div>

<div class="input-description"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it looks when we add the text inside the brackets() into the input-description?

@alexander-schranz alexander-schranz changed the title Feature/3 short title Added short title to fields Nov 16, 2016
@alexander-schranz alexander-schranz merged commit d52d5e9 into sulu:master Nov 17, 2016
@rs2487 rs2487 deleted the feature/3-short-title branch December 21, 2016 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a shortTitle to the fieldTranslation to use it in emails
2 participants