Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dimension Entity #174

Merged
merged 12 commits into from
Jan 14, 2021
Merged

Remove Dimension Entity #174

merged 12 commits into from
Jan 14, 2021

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Dec 16, 2020 •
edited by niklasnatter
Loading

This contains a few BC breaks which is documented in the. UPGRADE.md.

Fixes: #83

TODO

  • Add missing tests
  • Increase coverage/coveralls to 100%
  • Create Doctrine Example Migration Class which supports multiple tables

@alexander-schranz alexander-schranz force-pushed the feature/remove-dimension-entity branch 22 times, most recently from c15f14b to d1e0fc9 Compare December 17, 2020 21:46
@alexander-schranz alexander-schranz changed the title WIP: Remove dimension entity Remove Dimension Entity Dec 17, 2020
@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Bundle label Dec 17, 2020
@alexander-schranz alexander-schranz force-pushed the feature/remove-dimension-entity branch 3 times, most recently from 530eac4 to 219fbe7 Compare December 17, 2020 22:25
@alexander-schranz alexander-schranz force-pushed the feature/remove-dimension-entity branch from f6fcbd7 to 7648eec Compare December 23, 2020 15:33
@alexander-schranz alexander-schranz force-pushed the feature/remove-dimension-entity branch 3 times, most recently from 120d7ae to 5fcf060 Compare January 8, 2021 14:42
@alexander-schranz alexander-schranz force-pushed the feature/remove-dimension-entity branch from 5fcf060 to 02e0e8a Compare January 11, 2021 21:17
@alexander-schranz alexander-schranz marked this pull request as ready for review January 11, 2021 21:40
@niklasnatter niklasnatter changed the base branch from master to 0.x January 12, 2021 13:22
niklasnatter
niklasnatter reviewed Jan 13, 2021
View reviewed changes
Copy link
Contributor

@niklasnatter niklasnatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙂

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
Content/Domain/Model/ContentRichEntityInterface.php Show resolved Hide resolved
Content/Domain/Model/DimensionContentCollection.php Show resolved Hide resolved
Content/Domain/Model/DimensionContentCollectionInterface.php Show resolved Hide resolved
Tests/Traits/CreateExampleTrait.php Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
@niklasnatter niklasnatter mentioned this pull request Jan 13, 2021
Open
@niklasnatter niklasnatter mentioned this pull request Jan 13, 2021
Open
2 tasks
@niklasnatter niklasnatter merged commit 29afa52 into sulu:0.x Jan 14, 2021
This was referenced Jan 14, 2021
Closed
Closed
Closed
@alexander-schranz alexander-schranz deleted the feature/remove-dimension-entity branch January 14, 2021 17:24
@alexander-schranz
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasnatter niklasnatter niklasnatter approved these changes

Assignees

@alexander-schranz alexander-schranz

@niklasnatter niklasnatter

Labels
Feature New functionality not yet included in Bundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline the attributes of the Dimension entity into the DimensionContent
2 participants
@alexander-schranz @niklasnatter