Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grab polineid from titles table inslucde of po_line table #1310

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Jan 23, 2024

Below are a couple examples where catkeys are working and not working on the server.
not working catkeys: 14181385 | 491281
working catkeys: 14428388

@jcoyne
Copy link
Contributor

jcoyne commented Jan 23, 2024

Can you explain the motivation behind this change?

@dnoneill
Copy link
Contributor Author

dnoneill commented Jan 23, 2024

@jcoyne I have updated the comment to include catkeys that aren't working with how the code is currently structured. This is in relation to issue 3754. I am guessing with the folio migration the old fields aren't getting written correctly but I am not an expert on how the code is structured. Cory definitely had the same worry about this change which is why it was pushed up but I am not expecting it to get merged immediatly. I just opened a PR so it wouldn't get lost in the branches.

@corylown
Copy link
Contributor

@dnoneill could we set this PR to draft until we've done further testing/analysis?

@dnoneill dnoneill marked this pull request as draft January 23, 2024 22:53
@cbeer
Copy link
Member

cbeer commented Jan 30, 2024

I don't think (titles.jsonb ->> 'instanceId')::uuid is an indexed column in the FOLIO database, but maybe/hopefully that changes in a new FOLIO release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants