add some Indexing and search behavior integration tests #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
force-pushed
the
indexing-integration-tests
branch
2 times, most recently
from
56ecfab
to
2d50ba3
Compare
ndushay
force-pushed
the
indexing-integration-tests
branch
3 times, most recently
from
2c5d87c
to
90c9320
Compare
justinlittman
approved these changes
Mar 13, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to sul-dlss-deprecated/dor_indexing/pull/37
QUESTION: will these tests slow the test suite substantially? Not sure how to mitigate that, if so. I'm striving to avoid creating and indexing documents for each test, since they need to be driven through the entire stack.
Why was this change made?
As discussed in Infra Dev Planning meeting on Tues 3/5/24, this PR introduces some integration tests that allow us to put arbitrary cocina objects into dor-services-app via factory_bot (see spec/factories/items.rb), index them using the Argo indexer (which calls the dor-indexing-app), and then use the Argo UI to search for the objects, ensure the search results are as expected, ditto the facets, blah blah.
I have some tests for tags and for titles in flight, too. Separate PRs to come.
How was this change tested?
CI