fix: optimize the deleteRole method (casbin#272)

Signed-off-by: imp2002 <[email protected]>
sukidayou · May 27, 2022 · 24826bc · 24826bc
1 parent 79ff3ff
commit 24826bc
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/main/java/org/casbin/jcasbin/rbac/Role.java b/src/main/java/org/casbin/jcasbin/rbac/Role.java
@@ -44,13 +44,12 @@ void addRole(Role role) {
     }
 
     void deleteRole(Role role) {
-        List<Role> toRemove = new ArrayList<>();
         for (Role r : roles) {
             if (r.name.equals(role.name)) {
-                toRemove.add(r);
+                roles.remove(r);
+                return;
             }
         }
-        roles.removeAll(toRemove);
     }
 
     boolean hasRole(String name, int hierarchyLevel) {
@@ -83,7 +82,7 @@ public String toString() {
             if (i == 0) {
                 names.append(role.name);
             } else {
-                names.append(", " + role.name);
+                names.append(", ").append(role.name);
             }
         }
         return name + " < " + names;