Added APIs for product #1
Conversation
|
Backend is working fine and integrated with BE. (+4) Async/Await used (+1) ES6 modules(+1) |
Guria
left a comment
Guria
left a comment
There was a problem hiding this comment.
Evaluation criteria
✔️ The getProductsList lambda function returns a correct response aka POINT1
- ➖ Function is not named properly. Function name, files paths, config has name from generated template.
- ➕ Function has proper
httpevent configured - ➖ Function has extra unneeded
httpevent configured - ➖
serverlessconfiguration for function is not part of PR, had to check it in a branch - ➖ function handler references to a schema from generated template which is irrelevant to implementation.
❌ - The getProductsByIdnot implemented aka POINT2
❓ Your own Frontend application is integrated with Product Service (/products API) and products from Product Service are represented on Frontend. But POINT2 were not done.
Additional (optional) tasks
✔️ Async/await is used in lambda functions
✔️ ES6 modules are used for Product Service implementation
✔️ Custom Webpack/ESBuild/etc is manually configured for Product Service. Not applicable for preconfigured/built-in bundlers that come with templates, plugins, etc.
❌ SWAGGER documentation was not created for Product Service
❌ Lambda handlers are not covered by basic UNIT tests
❓ There is only one lambda, so can't apply additional point for code separation.
❌ Main error scenarios are not handled by API
Additional notes
- PR contains changes irrelevant to task, which makes making review harder
- PR doesn't contain changes relevant to task (eg, serverless config), which also makes making review harder
- There is not much effort done compared to generated template code. All of optioanl tasks points earned for free by using template.
- I would add additional point for working FE integration, but criteria says it must include 2 functions implemented on BE to be earned
Evaluation
- 2 points for implementing
getProductsList - 3 extra points
- Total: 5
| // message: `Hello ${event.body.name}, welcome to the exciting Serverless world!`, | ||
| event, | ||
| }); | ||
| return formatJSONResponse(products as any); |
There was a problem hiding this comment.
You can avoid casting to any if you remove unrelevant schema import and usage.
| @@ -0,0 +1,30 @@ | |||
| { | |||
There was a problem hiding this comment.
This service seems unrelevant to the task and looks like just generated template.
What was done?
Link to Product Service API -
Link to FE PR - ...
sujit-epam/shop-react-redux-cloudfront#2